gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove caching of streamID lengths in StreamFrame

Browse Source 
fixes the final failing test of #83
This commit is contained in:
Lucas Clemente
2016-07-08 18:05:47 +02:00
parent 87c1a2f004
commit 37f2066933
3 changed files with 16 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
frames/stream_frame_test.go
View File

@@ -248,16 +248,6 @@ var _ = Describe("StreamFrame", func() {
})
Context("lengths of StreamIDs", func() {
It("returns an error for a non-valid StreamID length", func() {
b := &bytes.Buffer{}
err := (&StreamFrame{
StreamID: 1,
streamIDLen: 13,
Data: []byte("foobar"),
}).Write(b, 0)
Expect(err).To(MatchError(errInvalidStreamIDLen))
})
It("writes a 1 byte StreamID", func() {
b := &bytes.Buffer{}
err := (&StreamFrame{
@@ -320,26 +310,22 @@ var _ = Describe("StreamFrame", func() {
Context("shortening of StreamIDs", func() {
It("determines the length of a 1 byte StreamID", func() {
f := &StreamFrame{StreamID: 0xFF}
f.calculateStreamIDLength()
Expect(f.streamIDLen).To(Equal(protocol.ByteCount(1)))
Expect(f.calculateStreamIDLength()).To(Equal(uint8(1)))
})
It("determines the length of a 2 byte StreamID", func() {
f := &StreamFrame{StreamID: 0xFFFF}
f.calculateStreamIDLength()
Expect(f.streamIDLen).To(Equal(protocol.ByteCount(2)))
Expect(f.calculateStreamIDLength()).To(Equal(uint8(2)))
})
It("determines the length of a 3 byte StreamID", func() {
f := &StreamFrame{StreamID: 0xFFFFFF}
f.calculateStreamIDLength()
Expect(f.streamIDLen).To(Equal(protocol.ByteCount(3)))
Expect(f.calculateStreamIDLength()).To(Equal(uint8(3)))
})
It("determines the length of a 4 byte StreamID", func() {
f := &StreamFrame{StreamID: 0xFFFFFFFF}
f.calculateStreamIDLength()
Expect(f.streamIDLen).To(Equal(protocol.ByteCount(4)))
Expect(f.calculateStreamIDLength()).To(Equal(uint8(4)))
})
})