From 37e57c6f05d3964b39a77a47c3a072165600ba33 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Wed, 15 Jun 2016 12:29:09 +0700 Subject: [PATCH] temporarily disable sending of Blocked frames ref #172 --- packet_packer.go | 1 + packet_packer_test.go | 2 +- session_test.go | 4 ++-- stream_test.go | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/packet_packer.go b/packet_packer.go index 69da81647..f52188957 100644 --- a/packet_packer.go +++ b/packet_packer.go @@ -55,6 +55,7 @@ func (p *packetPacker) AddHighPrioStreamFrame(f frames.StreamFrame) { } func (p *packetPacker) AddBlocked(streamID protocol.StreamID, byteOffset protocol.ByteCount) { + return // TODO: send out connection-level BlockedFrames at the right time // see https://github.com/lucas-clemente/quic-go/issues/113 // TODO: remove this function completely once #113 is resolved diff --git a/packet_packer_test.go b/packet_packer_test.go index 96bde5ce8..f1e9e83fe 100644 --- a/packet_packer_test.go +++ b/packet_packer_test.go @@ -393,7 +393,7 @@ var _ = Describe("Packet packer", func() { }) }) - Context("Blocked frames", func() { + PContext("Blocked frames", func() { It("adds a blocked frame to a packet if there is enough space", func() { length := 100 packer.AddBlocked(5, protocol.ByteCount(length)) diff --git a/session_test.go b/session_test.go index bff1117ff..bffeefc62 100644 --- a/session_test.go +++ b/session_test.go @@ -203,7 +203,7 @@ var _ = Describe("Session", func() { Expect(session.streamFrameQueue.Pop(1000)).To(BeNil()) }) - It("removes closed streams from BlockedManager", func() { + PIt("removes closed streams from BlockedManager", func() { session.handleStreamFrame(&frames.StreamFrame{ StreamID: 5, Data: []byte{0xde, 0xca, 0xfb, 0xad}, @@ -444,7 +444,7 @@ var _ = Describe("Session", func() { Expect(conn.written[0]).To(ContainSubstring(string([]byte("PRST")))) }) - Context("Blocked", func() { + PContext("Blocked", func() { It("queues a Blocked frames", func() { len := 500 frame := frames.StreamFrame{ diff --git a/stream_test.go b/stream_test.go index ad8458d7f..1c208d763 100644 --- a/stream_test.go +++ b/stream_test.go @@ -499,7 +499,7 @@ var _ = Describe("Stream", func() { }) }) - Context("Blocked streams", func() { + PContext("Blocked streams", func() { It("notifies the session when a stream is flow control blocked", func() { updated := str.flowController.UpdateSendWindow(1337) Expect(updated).To(BeTrue())