gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

http3: reject duplicate pseudo headers (#4993)

Browse Source
This commit is contained in:
pittgi
2025-03-16 03:52:25 +01:00
committed by GitHub
parent 8f23c8a404
commit 3311514d67
2 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
http3/headers_test.go
View File

@@ -235,6 +235,18 @@ var _ = Describe("Request", func() {
Expect(err).To(MatchError(":protocol must be empty"))
})
It("errors with duplicate pseudo header in request", func() {
headers := []qpack.HeaderField{
{Name: ":path", Value: "/foo"},
{Name: ":authority", Value: "quic.clemente.io"},
{Name: ":method", Value: "GET"},
{Name: ":scheme", Value: "https"},
{Name: ":method", Value: "POST"},
}
_, err := requestFromHeaders(headers)
Expect(err).To(MatchError("duplicate pseudo header: :method"))
})
Context("regular HTTP CONNECT", func() {
It("handles CONNECT method", func() {
headers := []qpack.HeaderField{
@@ -432,4 +444,13 @@ var _ = Describe("Response", func() {
_, err := parseTrailers(headers)
Expect(err).To(MatchError("http3: received pseudo header in trailer: :status"))
})
It("errors with duplicate status header in response", func() {
headers := []qpack.HeaderField{
{Name: ":status", Value: "200"},
{Name: ":status", Value: "400"},
}
err := updateResponseFromHeaders(&http.Response{}, headers)
Expect(err).To(MatchError("duplicate pseudo header: :status"))
})
})