From 45963c11dc7129d56832252ef72be4c81c38ffb0 Mon Sep 17 00:00:00 2001
From: Marten Seemann <martenseemann@gmail.com>
Date: Sat, 21 Nov 2020 10:53:14 +0700
Subject: [PATCH] use the string optimization for map keys

---
 packet_handler_map.go | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/packet_handler_map.go b/packet_handler_map.go
index ae542e59a..b982e16fd 100644
--- a/packet_handler_map.go
+++ b/packet_handler_map.go
@@ -147,32 +147,29 @@ func (h *packetHandlerMap) logUsage() {
 }
 
 func (h *packetHandlerMap) Add(id protocol.ConnectionID, handler packetHandler) bool /* was added */ {
-	sid := string(id)
-
 	h.mutex.Lock()
 	defer h.mutex.Unlock()
 
-	if _, ok := h.handlers[sid]; ok {
+	if _, ok := h.handlers[string(id)]; ok {
 		h.logger.Debugf("Not adding connection ID %s, as it already exists.", id)
 		return false
 	}
-	h.handlers[sid] = handler
+	h.handlers[string(id)] = handler
 	h.logger.Debugf("Adding connection ID %s.", id)
 	return true
 }
 
 func (h *packetHandlerMap) AddWithConnID(clientDestConnID, newConnID protocol.ConnectionID, fn func() packetHandler) bool {
-	sid := string(clientDestConnID)
 	h.mutex.Lock()
 	defer h.mutex.Unlock()
 
-	if _, ok := h.handlers[sid]; ok {
+	if _, ok := h.handlers[string(clientDestConnID)]; ok {
 		h.logger.Debugf("Not adding connection ID %s for a new session, as it already exists.", clientDestConnID)
 		return false
 	}
 
 	sess := fn()
-	h.handlers[sid] = sess
+	h.handlers[string(clientDestConnID)] = sess
 	h.handlers[string(newConnID)] = sess
 	h.logger.Debugf("Adding connection IDs %s and %s for a new session.", clientDestConnID, newConnID)
 	return true