From 30dede980309ae614fe930bb52a50f5887d52215 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sat, 7 Jun 2025 13:09:37 +0800 Subject: [PATCH] ci: remove leftover check for Ginkgo imports (#5198) --- .github/workflows/lint.yml | 2 -- .github/workflows/no_ginkgo.sh | 24 ------------------------ 2 files changed, 26 deletions(-) delete mode 100755 .github/workflows/no_ginkgo.sh diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 2ce5cf57c..844f64d0c 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -9,8 +9,6 @@ jobs: - uses: actions/setup-go@v5 with: go-version: "1.24.x" - - name: Check that no non-test files import Ginkgo or Gomega - run: .github/workflows/no_ginkgo.sh - name: Check for //go:build ignore in .go files run: | IGNORED_FILES=$(grep -rl '//go:build ignore' . --include='*.go') || true diff --git a/.github/workflows/no_ginkgo.sh b/.github/workflows/no_ginkgo.sh deleted file mode 100755 index 8857d98af..000000000 --- a/.github/workflows/no_ginkgo.sh +++ /dev/null @@ -1,24 +0,0 @@ -#!/usr/bin/env bash - -# Verify that no non-test files import Ginkgo or Gomega. - -set -e - -HAS_TESTING=false - -cd .. -for f in $(find . -name "*.go" ! -name "*_test.go" ! -name "tools.go"); do - if grep -q "github.com/onsi/ginkgo" $f; then - echo "$f imports github.com/onsi/ginkgo/v2" - HAS_TESTING=true - fi - if grep -q "github.com/onsi/gomega" $f; then - echo "$f imports github.com/onsi/gomega" - HAS_TESTING=true - fi -done - -if "$HAS_TESTING"; then - exit 1 -fi -exit 0