From 2d98933d69d5f08bcedc1a82cfea55c0e921f105 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Tue, 16 Aug 2016 13:39:26 +0700 Subject: [PATCH] fix flaky proxy tests fixes #275 --- integrationtests/proxy/udp_proxy_test.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/integrationtests/proxy/udp_proxy_test.go b/integrationtests/proxy/udp_proxy_test.go index fd7e2955..07428a3b 100644 --- a/integrationtests/proxy/udp_proxy_test.go +++ b/integrationtests/proxy/udp_proxy_test.go @@ -4,6 +4,7 @@ import ( "bytes" "net" "strconv" + "sync/atomic" "time" "github.com/lucas-clemente/quic-go" @@ -130,7 +131,7 @@ var _ = Describe("UDP Proxy", func() { Eventually(func() map[string]*connection { return proxy.clientDict }).Should(HaveLen(1)) var conn *connection for _, conn = range proxy.clientDict { - Expect(conn.incomingPacketCounter).To(Equal(uint64(1))) + Expect(atomic.LoadUint64(&conn.incomingPacketCounter)).To(Equal(uint64(1))) } _, err = clientConn.Write(makePacket(2, []byte("decafbad"))) Expect(err).ToNot(HaveOccurred()) @@ -147,7 +148,7 @@ var _ = Describe("UDP Proxy", func() { var key string var conn *connection for key, conn = range proxy.clientDict { - Eventually(conn.outgoingPacketCounter).Should(Equal(uint64(1))) + Eventually(func() uint64 { return atomic.LoadUint64(&conn.outgoingPacketCounter) }).Should(Equal(uint64(1))) } _, err = clientConn.Write(makePacket(2, []byte("decafbad"))) Expect(err).ToNot(HaveOccurred())