gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

wire: reject NEW_CONNECTION_ID frames with zero-length conneciton IDs (#4180)

Browse Source
This commit is contained in:
Marten Seemann
2023-11-23 17:41:12 +07:00
committed by GitHub
parent 771d136fa9
commit 2d7ea37672
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
internal/wire/new_connection_id_frame_test.go
View File

@@ -38,7 +38,15 @@ var _ = Describe("NEW_CONNECTION_ID frame", func() {
Expect(err).To(MatchError("Retire Prior To value (1001) larger than Sequence Number (1000)"))
})
It("errors when the connection ID has an invalid length", func() {
It("errors when the connection ID has a zero-length connection ID", func() {
data := encodeVarInt(42) // sequence number
data = append(data, encodeVarInt(12)...) // retire prior to
data = append(data, 0) // connection ID length
_, err := parseNewConnectionIDFrame(bytes.NewReader(data), protocol.Version1)
Expect(err).To(MatchError("invalid zero-length connection ID"))
})
It("errors when the connection ID has an invalid length (too long)", func() {
data := encodeVarInt(0xdeadbeef) // sequence number
data = append(data, encodeVarInt(0xcafe)...) // retire prior to
data = append(data, 21) // connection ID length