gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

don't send greased version numbers for gQUIC

Browse Source
This commit is contained in:
Marten Seemann
2018-02-25 19:35:10 +08:00
parent e26c1f09de
commit 2ab2baf4bc
4 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/wire/version_negotiation.go
View File

@@ -21,7 +21,7 @@ func ComposeGQUICVersionNegotiation(connID protocol.ConnectionID, versions []pro
utils.Errorf("error composing version negotiation packet: %s", err.Error())
return nil
}
for _, v := range protocol.GetGreasedVersions(versions) {
for _, v := range versions {
utils.BigEndian.WriteUint32(buf, uint32(v))
}
return buf.Bytes()

6
internal/wire/version_negotiation_test.go
View File

@@ -16,11 +16,7 @@ var _ = Describe("Version Negotiation Packets", func() {
Expect(err).ToNot(HaveOccurred())
Expect(hdr.VersionFlag).To(BeTrue())
Expect(hdr.ConnectionID).To(Equal(protocol.ConnectionID(0x1337)))
// the supported versions should include one reserved version number
Expect(hdr.SupportedVersions).To(HaveLen(len(versions) + 1))
for _, version := range versions {
Expect(hdr.SupportedVersions).To(ContainElement(version))
}
Expect(hdr.SupportedVersions).To(Equal(versions))
})
It("writes in IETF draft style", func() {