drop support for QUIC 34

fixes #368

protocol/version.go

@@ -11,8 +11,7 @@ type VersionNumber int
 
 // The version numbers, making grepping easier
 const (
-	Version34 VersionNumber = 34 + iota
-	Version35
+	Version35 VersionNumber = 35 + iota
 	Version36
 	VersionWhatever    = 0 // for when the version doesn't matter
 	VersionUnsupported = -1
@@ -21,7 +20,7 @@ const (
 // SupportedVersions lists the versions that the server supports
 // must be in sorted order
 var SupportedVersions = []VersionNumber{
-	Version34, Version35, Version36,
+	Version35, Version36,
 }
 
 // SupportedVersionsAsTags is needed for the SHLO crypto message

protocol/version_test.go

@@ -8,20 +8,18 @@ import (
 var _ = Describe("Version", func() {
 	It("converts tags to numbers", func() {
 		Expect(VersionTagToNumber('Q' + '1'<<8 + '2'<<16 + '3'<<24)).To(Equal(VersionNumber(123)))
-		Expect(VersionTagToNumber('Q' + '0'<<8 + '3'<<16 + '4'<<24)).To(Equal(Version34))
 	})
 
 	It("converts number to tag", func() {
 		Expect(VersionNumberToTag(VersionNumber(123))).To(Equal(uint32('Q' + '1'<<8 + '2'<<16 + '3'<<24)))
-		Expect(VersionNumberToTag(Version34)).To(Equal(uint32('Q' + '0'<<8 + '3'<<16 + '4'<<24)))
 	})
 
 	It("has proper tag list", func() {
-		Expect(SupportedVersionsAsTags).To(Equal([]byte("Q034Q035Q036")))
+		Expect(SupportedVersionsAsTags).To(Equal([]byte("Q035Q036")))
 	})
 
 	It("has proper version list", func() {
-		Expect(SupportedVersionsAsString).To(Equal("36,35,34"))
+		Expect(SupportedVersionsAsString).To(Equal("36,35"))
 	})
 
 	It("recognizes supported versions", func() {