From 2864c97a7060de70798405e09d20eb80dbab7ed8 Mon Sep 17 00:00:00 2001 From: Lucas Clemente Date: Tue, 17 May 2016 19:22:18 +0200 Subject: [PATCH] remove outdated TODOs --- congestion/interface.go | 1 - session.go | 1 - utils/utils.go | 1 - 3 files changed, 3 deletions(-) diff --git a/congestion/interface.go b/congestion/interface.go index d98b69784..593c09e7c 100644 --- a/congestion/interface.go +++ b/congestion/interface.go @@ -27,7 +27,6 @@ type SendAlgorithmWithDebugInfo interface { BandwidthEstimate() Bandwidth // Stuff only used in testing - // TODO: Maybe make CubicSender public and typeassert in tests? HybridSlowStart() *HybridSlowStart SlowstartThreshold() protocol.PacketNumber diff --git a/session.go b/session.go index b0d6fc8a4..a3cf1e829 100644 --- a/session.go +++ b/session.go @@ -211,7 +211,6 @@ func (s *Session) handlePacketImpl(remoteAddr interface{}, hdr *publicHeader, da case *frames.StreamFrame: utils.Debugf("\t<- &frames.StreamFrame{StreamID: %d, FinBit: %t, Offset: 0x%x, Data length: 0x%x, Offset + Data length: 0x%x}", frame.StreamID, frame.FinBit, frame.Offset, len(frame.Data), frame.Offset+protocol.ByteCount(len(frame.Data))) err = s.handleStreamFrame(frame) - // TODO: send error for flow control violation // TODO: send RstStreamFrame case *frames.AckFrame: err = s.handleAckFrame(frame) diff --git a/utils/utils.go b/utils/utils.go index 3ba10938c..9c4aa5f26 100644 --- a/utils/utils.go +++ b/utils/utils.go @@ -164,7 +164,6 @@ func WriteUint16(b *bytes.Buffer, i uint16) { // RandomBit returns a cryptographically secure random bit (encoded as true / false) func RandomBit() (bool, error) { - // TODO: it's probably more efficient to read a bigger slice of random numbers at once and to cache them somewhere b := make([]byte, 1) _, err := rand.Read(b) if err != nil {