gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

enforce that a conn ID is not retired in a packet that uses that conn ID

Browse Source
This commit is contained in:
Marten Seemann
2020-07-06 16:27:29 +07:00
parent 5227fef1a3
commit 25db2166dd
4 changed files with 37 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
conn_id_generator.go
View File

@@ -67,7 +67,7 @@ func (m *connIDGenerator) SetMaxActiveConnIDs(limit uint64) error {
return nil
}
func (m *connIDGenerator) Retire(seq uint64) error {
func (m *connIDGenerator) Retire(seq uint64, sentWithDestConnID protocol.ConnectionID) error {
if seq > m.highestSeq {
return qerr.NewError(qerr.ProtocolViolation, fmt.Sprintf("tried to retire connection ID %d. Highest issued: %d", seq, m.highestSeq))
}
@@ -76,6 +76,9 @@ func (m *connIDGenerator) Retire(seq uint64) error {
if !ok {
return nil
}
if connID.Equal(sentWithDestConnID) {
return qerr.NewError(qerr.FrameEncodingError, fmt.Sprintf("tried to retire connection ID %d (%s), which was used as the Destination Connection ID on this packet", seq, connID))
}
m.retireConnectionID(connID)
delete(m.activeSrcConnIDs, seq)
// Don't issue a replacement for the initial connection ID.