gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

Merge pull request #1566 from lucas-clemente/better-stream-helpers

Browse Source 
simplify the streamsMap by using the stream helper functions
This commit is contained in:
Marten Seemann
2018-11-01 16:22:20 +07:00
committed by GitHub
parent 2bfe8d0b77 44243b4f52
commit 257c4732c3
4 changed files with 63 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
internal/protocol/stream_id.go
View File

@@ -3,6 +3,16 @@ package protocol
// A StreamID in QUIC
type StreamID uint64
// StreamType encodes if this is a unidirectional or bidirectional stream
type StreamType uint8
const (
// StreamTypeUni is a unidirectional stream
StreamTypeUni StreamType = iota
// StreamTypeBidi is a bidirectional stream
StreamTypeBidi
)
// InitiatedBy says if the stream was initiated by the client or by the server
func (s StreamID) InitiatedBy() Perspective {
if s%2 == 0 {
@@ -11,9 +21,12 @@ func (s StreamID) InitiatedBy() Perspective {
return PerspectiveServer
}
// IsUniDirectional says if this is a unidirectional stream (true) or not (false)
func (s StreamID) IsUniDirectional() bool {
return s%4 >= 2
//Type says if this is a unidirectional or bidirectional stream
func (s StreamID) Type() StreamType {
if s%4 >= 2 {
return StreamTypeUni
}
return StreamTypeBidi
}
// MaxBidiStreamID is the highest stream ID that the peer is allowed to open,

8
internal/protocol/stream_id_test.go
View File

@@ -14,10 +14,10 @@ var _ = Describe("Stream ID", func() {
})
It("tells the directionality", func() {
Expect(StreamID(4).IsUniDirectional()).To(BeFalse())
Expect(StreamID(5).IsUniDirectional()).To(BeFalse())
Expect(StreamID(6).IsUniDirectional()).To(BeTrue())
Expect(StreamID(7).IsUniDirectional()).To(BeTrue())
Expect(StreamID(4).Type()).To(Equal(StreamTypeBidi))
Expect(StreamID(5).Type()).To(Equal(StreamTypeBidi))
Expect(StreamID(6).Type()).To(Equal(StreamTypeUni))
Expect(StreamID(7).Type()).To(Equal(StreamTypeUni))
})
Context("maximum stream IDs", func() {