fix panic in QUIC 34 ACK frame parser for incorrect typeBytes

fixes #198
2016-07-05 15:10:22 +08:00
parent da2b2f3a2d
commit 1fc83757a0
2 changed files with 10 additions and 0 deletions
--- a/frames/ack_frame_new.go
+++ b/frames/ack_frame_new.go
@@ -75,6 +75,10 @@ func ParseAckFrameNew(r *bytes.Reader, version protocol.VersionNumber) (*AckFram
 		}
 	}

+	if hasMissingRanges && numAckBlocks == 0 {
+		return nil, ErrInvalidAckRanges
+	}
+
 	ackBlockLength, err := utils.ReadUintN(r, missingSequenceNumberDeltaLen)
 	if err != nil {
 		return nil, err