gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

protocol: remove VersionTLS, used during the gQUIC -> TLS 1.3 transition (#3764)

Browse Source
This commit is contained in:
Marten Seemann
2023-04-19 16:24:34 +02:00
committed by GitHub
parent a753cb13d8
commit 1f57d4e789
21 changed files with 68 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/protocol/version.go
View File

@@ -18,7 +18,6 @@ const (
// The version numbers, making grepping easier
const (
VersionTLS VersionNumber = 0x1
VersionUnknown VersionNumber = math.MaxUint32
VersionDraft29 VersionNumber = 0xff00001d
Version1 VersionNumber = 0x1
@@ -31,15 +30,10 @@ var SupportedVersions = []VersionNumber{Version1, Version2, VersionDraft29}
// IsValidVersion says if the version is known to quic-go
func IsValidVersion(v VersionNumber) bool {
return v == VersionTLS || IsSupportedVersion(SupportedVersions, v)
return v == Version1 || IsSupportedVersion(SupportedVersions, v)
}
func (vn VersionNumber) String() string {
// For releases, VersionTLS will be set to a draft version.
// A switch statement can't contain duplicate cases.
if vn == VersionTLS && VersionTLS != VersionDraft29 && VersionTLS != Version1 {
return "TLS dev version (WIP)"
}
//nolint:exhaustive
switch vn {
case VersionUnknown:

5
internal/protocol/version_test.go
View File

@@ -11,7 +11,6 @@ var _ = Describe("Version", func() {
}
It("says if a version is valid", func() {
Expect(IsValidVersion(VersionTLS)).To(BeTrue())
Expect(IsValidVersion(VersionUnknown)).To(BeFalse())
Expect(IsValidVersion(VersionDraft29)).To(BeTrue())
Expect(IsValidVersion(Version1)).To(BeTrue())
@@ -19,10 +18,6 @@ var _ = Describe("Version", func() {
Expect(IsValidVersion(1234)).To(BeFalse())
})
It("versions don't have reserved version numbers", func() {
Expect(isReservedVersion(VersionTLS)).To(BeFalse())
})
It("has the right string representation", func() {
Expect(VersionUnknown.String()).To(Equal("unknown"))
Expect(VersionDraft29.String()).To(Equal("draft-29"))