From 1f4335ffcea236e061c6d2fa5908ed689fb930e9 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sun, 1 Jul 2018 11:13:52 +0700 Subject: [PATCH] fix buffer size for version negotiation packets --- internal/wire/version_negotiation.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/internal/wire/version_negotiation.go b/internal/wire/version_negotiation.go index a19f27679..df8b1f2cf 100644 --- a/internal/wire/version_negotiation.go +++ b/internal/wire/version_negotiation.go @@ -22,7 +22,8 @@ func ComposeGQUICVersionNegotiation(connID protocol.ConnectionID, versions []pro // ComposeVersionNegotiation composes a Version Negotiation according to the IETF draft func ComposeVersionNegotiation(destConnID, srcConnID protocol.ConnectionID, versions []protocol.VersionNumber) ([]byte, error) { greasedVersions := protocol.GetGreasedVersions(versions) - buf := bytes.NewBuffer(make([]byte, 0, 1+8+4+len(greasedVersions)*4)) + expectedLen := 1 /* type byte */ + 4 /* version field */ + 1 /* connection ID length field */ + destConnID.Len() + srcConnID.Len() + len(greasedVersions)*4 + buf := bytes.NewBuffer(make([]byte, 0, expectedLen)) r := make([]byte, 1) _, _ = rand.Read(r) // ignore the error here. It is not critical to have perfect random here. buf.WriteByte(r[0] | 0x80)