From 1491bc20f46fb67fe0efcd6f82a1302ff2174ccc Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Thu, 9 Jun 2016 11:42:37 +0700 Subject: [PATCH] fix flaky tests on AppVeyor --- h2quic/server_test.go | 2 +- session.go | 2 +- session_test.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/h2quic/server_test.go b/h2quic/server_test.go index c18c00f0..2780e5b8 100644 --- a/h2quic/server_test.go +++ b/h2quic/server_test.go @@ -236,7 +236,7 @@ var _ = Describe("H2 server", func() { Expect(err).NotTo(HaveOccurred()) close(done) }() - time.Sleep(10 * time.Millisecond) + time.Sleep(50 * time.Millisecond) err := s.Close() Expect(err).NotTo(HaveOccurred()) }, 0.5) diff --git a/session.go b/session.go index fb350602..86a417bd 100644 --- a/session.go +++ b/session.go @@ -171,7 +171,7 @@ func (s *Session) run() { if err := s.maybeSendPacket(); err != nil { s.Close(err) } - if time.Now().Sub(s.lastNetworkActivityTime) > s.connectionParametersManager.GetIdleConnectionStateLifetime() { + if time.Now().Sub(s.lastNetworkActivityTime) >= s.connectionParametersManager.GetIdleConnectionStateLifetime() { s.Close(qerr.Error(qerr.NetworkIdleTimeout, "No recent network activity.")) } s.garbageCollectStreams() diff --git a/session_test.go b/session_test.go index 88c95ef8..835a808c 100644 --- a/session_test.go +++ b/session_test.go @@ -633,7 +633,7 @@ var _ = Describe("Session", func() { session.run() // Would normally not return Expect(conn.written[0]).To(ContainSubstring("No recent network activity.")) close(done) - }, 0.5) + }, 3) It("errors when the SentPacketHandler has too many packets tracked", func() { streamFrame := frames.StreamFrame{StreamID: 5, Data: []byte("foobar")}