gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

Fix unnecessary stack growth when parsing frames

Browse Source
This commit is contained in:
Lucas Clemente
2018-04-30 10:28:18 +02:00
committed by GitHub
parent 0aa793876c
commit 0d8f0be92b
1 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/wire/frame_parser.go
View File

@@ -11,12 +11,10 @@ import (
// ParseNextFrame parses the next frame // ParseNextFrame parses the next frame
// It skips PADDING frames. // It skips PADDING frames.
func ParseNextFrame(r *bytes.Reader, hdr *Header, v protocol.VersionNumber) (Frame, error) { func ParseNextFrame(r *bytes.Reader, hdr *Header, v protocol.VersionNumber) (Frame, error) {
if r.Len() == 0 { for r.Len() != 0 {
return nil, nil
}
typeByte, _ := r.ReadByte() typeByte, _ := r.ReadByte()
if typeByte == 0x0 { // PADDING frame if typeByte == 0x0 { // PADDING frame
return ParseNextFrame(r, hdr, v) continue
} }
r.UnreadByte() r.UnreadByte()
@@ -25,6 +23,8 @@ func ParseNextFrame(r *bytes.Reader, hdr *Header, v protocol.VersionNumber) (Fra
} }
return parseIETFFrame(r, typeByte, v) return parseIETFFrame(r, typeByte, v)
} }
return nil, nil
}
func parseIETFFrame(r *bytes.Reader, typeByte byte, v protocol.VersionNumber) (Frame, error) { func parseIETFFrame(r *bytes.Reader, typeByte byte, v protocol.VersionNumber) (Frame, error) {
var frame Frame var frame Frame