gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

remove redundant bool return value from sendStream.popStreamFrame (#4828)

Browse Source
This commit is contained in:
Marten Seemann
2024-12-31 13:51:14 +08:00
committed by GitHub
parent f337891fc8
commit 0b9bd3c4de
8 changed files with 152 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
framer.go
View File

@@ -196,7 +196,7 @@ func (f *framer) AppendStreamFrames(frames []ackhandler.StreamFrame, maxLen prot
// Therefore, we can pretend to have more bytes available when popping
// the STREAM frame (which will always have the DataLen set).
remainingLen += protocol.ByteCount(quicvarint.Len(uint64(remainingLen)))
frame, ok, hasMoreData := str.popStreamFrame(remainingLen, v)
frame, hasMoreData := str.popStreamFrame(remainingLen, v)
if hasMoreData { // put the stream back in the queue (at the end)
f.streamQueue.PushBack(id)
} else { // no more data to send. Stream is not active
@@ -205,7 +205,7 @@ func (f *framer) AppendStreamFrames(frames []ackhandler.StreamFrame, maxLen prot
// The frame can be "nil"
// * if the stream was canceled after it said it had data
// * the remaining size doesn't allow us to add another STREAM frame
if !ok {
if frame.Frame == nil {
continue
}
frames = append(frames, frame)