gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

reduce the size of messageChan channel in the crypto setup (#3664)

Browse Source
This commit is contained in:
Marten Seemann
2023-02-14 10:55:49 +13:00
committed by GitHub
parent 04c3fd0756
commit 0ac5d1c149
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
internal/handshake/crypto_setup.go
View File

@@ -263,7 +263,7 @@ func newCryptoSetup(
alertChan: make(chan uint8), alertChan: make(chan uint8),
clientHelloWrittenChan: make(chan struct{}), clientHelloWrittenChan: make(chan struct{}),
zeroRTTParametersChan: zeroRTTParametersChan, zeroRTTParametersChan: zeroRTTParametersChan,
messageChan: make(chan []byte, 100), messageChan: make(chan []byte, 1),
isReadingHandshakeMessage: make(chan struct{}), isReadingHandshakeMessage: make(chan struct{}),
closeChan: make(chan struct{}), closeChan: make(chan struct{}),
version: version, version: version,
@@ -368,8 +368,15 @@ func (h *cryptoSetup) HandleMessage(data []byte, encLevel protocol.EncryptionLev
h.onError(alertUnexpectedMessage, err.Error()) h.onError(alertUnexpectedMessage, err.Error())
return false return false
} }
h.messageChan <- data if encLevel != protocol.Encryption1RTT {
select {
case h.messageChan <- data:
case <-h.handshakeDone: // handshake errored, nobody is going to consume this message
return false
}
}
if encLevel == protocol.Encryption1RTT { if encLevel == protocol.Encryption1RTT {
h.messageChan <- data
h.handlePostHandshakeMessage() h.handlePostHandshakeMessage()
return false return false
} }