gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

Merge pull request #1712 from lucas-clemente/fix-ack-delay-for-pn0

Browse Source 
correctly set the ack delay in an ACK of packet number 0
This commit is contained in:
Marten Seemann
2019-01-07 08:44:32 +07:00
committed by GitHub
parent 4294493a1a 5e3c96024a
commit 086cc85b98
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/ackhandler/received_packet_handler.go
View File

@@ -74,7 +74,7 @@ func (h *receivedPacketHandler) ReceivedPacket(packetNumber protocol.PacketNumbe
} }
isMissing := h.isMissing(packetNumber) isMissing := h.isMissing(packetNumber)
if packetNumber > h.largestObserved { if packetNumber >= h.largestObserved {
h.largestObserved = packetNumber h.largestObserved = packetNumber
h.largestObservedReceivedTime = rcvTime h.largestObservedReceivedTime = rcvTime
} }

8
internal/ackhandler/received_packet_handler_test.go
View File

@@ -95,17 +95,17 @@ var _ = Describe("receivedPacketHandler", func() {
} }
It("always queues an ACK for the first packet", func() { It("always queues an ACK for the first packet", func() {
err := handler.ReceivedPacket(1, time.Time{}, false) Expect(handler.ReceivedPacket(1, time.Now(), false)).To(Succeed())
Expect(err).ToNot(HaveOccurred())
Expect(handler.ackQueued).To(BeTrue()) Expect(handler.ackQueued).To(BeTrue())
Expect(handler.GetAlarmTimeout()).To(BeZero()) Expect(handler.GetAlarmTimeout()).To(BeZero())
Expect(handler.GetAckFrame().DelayTime).To(BeNumerically("~", 0, time.Second))
}) })
It("works with packet number 0", func() { It("works with packet number 0", func() {
err := handler.ReceivedPacket(0, time.Time{}, false) Expect(handler.ReceivedPacket(0, time.Now(), false)).To(Succeed())
Expect(err).ToNot(HaveOccurred())
Expect(handler.ackQueued).To(BeTrue()) Expect(handler.ackQueued).To(BeTrue())
Expect(handler.GetAlarmTimeout()).To(BeZero()) Expect(handler.GetAlarmTimeout()).To(BeZero())
Expect(handler.GetAckFrame().DelayTime).To(BeNumerically("~", 0, time.Second))
}) })
It("queues an ACK for every second retransmittable packet at the beginning", func() { It("queues an ACK for every second retransmittable packet at the beginning", func() {