From 06ee16ee6789f99b8584c7ae8204ef78d4362bdd Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Sat, 31 May 2025 11:01:47 +0800 Subject: [PATCH] fix flaky TestDatagramLoss (#5174) --- integrationtests/self/datagram_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/integrationtests/self/datagram_test.go b/integrationtests/self/datagram_test.go index 6c6673aa4..fdc499f69 100644 --- a/integrationtests/self/datagram_test.go +++ b/integrationtests/self/datagram_test.go @@ -140,7 +140,6 @@ func TestDatagramLoss(t *testing.T) { proxy := &quicproxy.Proxy{ Conn: newUDPConnLocalhost(t), ServerAddr: server.Addr().(*net.UDPAddr), - // Drop about 10% of Short Header packets with DATAGRAM frames DropPacket: func(dir quicproxy.Direction, _, _ net.Addr, packet []byte) bool { if wire.IsLongHeaderPacket(packet[0]) { // don't drop Long Header packets return false @@ -149,7 +148,8 @@ func TestDatagramLoss(t *testing.T) { return false } total.Add(1) - if mrand.Int()%10 == 0 { + // drop about 20% of Short Header packets with DATAGRAM frames + if mrand.Int()%5 == 0 { switch dir { case quicproxy.DirectionIncoming: droppedIncoming.Add(1) @@ -196,7 +196,7 @@ func TestDatagramLoss(t *testing.T) { } }() - for i := 0; i < numDatagrams; i++ { + for i := range numDatagrams { payload := bytes.Repeat([]byte{uint8(i)}, datagramSize) require.NoError(t, clientConn.SendDatagram(payload)) require.NoError(t, serverConn.SendDatagram(payload))