From 0696cd51bf07908f135901480790aa2891b68e3e Mon Sep 17 00:00:00 2001 From: Lucas Clemente Date: Sat, 6 Aug 2016 17:45:32 +0200 Subject: [PATCH] add a buffer pool test for wrong-sized puts --- buffer_pool.go | 1 - buffer_pool_test.go | 6 ++++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/buffer_pool.go b/buffer_pool.go index 40ff3bfc2..bb4feb318 100644 --- a/buffer_pool.go +++ b/buffer_pool.go @@ -14,7 +14,6 @@ func getPacketBuffer() []byte { func putPacketBuffer(buf []byte) { if cap(buf) != int(protocol.MaxPacketSize) { - println(buf) panic("putPacketBuffer called with packet of wrong size!") } bufferPool.Put(buf[:0]) diff --git a/buffer_pool_test.go b/buffer_pool_test.go index 9fa1a53f1..5d64c6b66 100644 --- a/buffer_pool_test.go +++ b/buffer_pool_test.go @@ -23,4 +23,10 @@ var _ = Describe("Buffer Pool", func() { Expect(buf).To(HaveCap(int(protocol.MaxPacketSize))) } }) + + It("panics if wrong-sized buffers are passed", func() { + Expect(func() { + putPacketBuffer([]byte{0}) + }).To(Panic()) + }) })