From 05645b546cf83bea74b8af8aacb9d30208295531 Mon Sep 17 00:00:00 2001 From: Marten Seemann Date: Tue, 1 Jan 2019 15:24:30 +0700 Subject: [PATCH] remove special case for Retry packets from the session Retry packets are never passed to the session, so there's no need to handle them there. --- session.go | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/session.go b/session.go index bb24c50e1..7f64c41e5 100644 --- a/session.go +++ b/session.go @@ -539,13 +539,9 @@ func (s *session) handleUnpackedPacket(packet *unpackedPacket, rcvTime time.Time } } - // If this is a Retry packet, there's no need to send an ACK. - // The session will be closed and recreated as soon as the crypto setup processed the HRR. - if packet.hdr.Type != protocol.PacketTypeRetry { - isRetransmittable := ackhandler.HasRetransmittableFrames(packet.frames) - if err := s.receivedPacketHandler.ReceivedPacket(packet.packetNumber, rcvTime, isRetransmittable); err != nil { - return err - } + isRetransmittable := ackhandler.HasRetransmittableFrames(packet.frames) + if err := s.receivedPacketHandler.ReceivedPacket(packet.packetNumber, rcvTime, isRetransmittable); err != nil { + return err } return s.handleFrames(packet.frames, packet.packetNumber, packet.encryptionLevel)