gr1ffon/quic-go
1
0
Fork 0
forked from quic-go/quic-go
Code Pull Requests Activity

privatize session.handlePacket

Browse Source 
ref #60
This commit is contained in:
Lucas Clemente
2016-05-15 18:48:11 +02:00
parent ce1f7b2aaf
commit 028615b8f0
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server.go
View File

@@ -14,7 +14,7 @@ import (
// packetHandler handles packets
type packetHandler interface {
HandlePacket(addr interface{}, hdr *publicHeader, data []byte)
handlePacket(addr interface{}, hdr *publicHeader, data []byte)
Run()
}
@@ -137,7 +137,7 @@ func (s *Server) handlePacket(conn *net.UDPConn, remoteAddr *net.UDPAddr, packet
// Late packet for closed session
return nil
}
session.HandlePacket(remoteAddr, hdr, packet[len(packet)-r.Len():])
session.handlePacket(remoteAddr, hdr, packet[len(packet)-r.Len():])
return nil
}

2
server_test.go
View File

@@ -18,7 +18,7 @@ type mockSession struct {
packetCount int
}
func (s *mockSession) HandlePacket(addr interface{}, hdr *publicHeader, data []byte) {
func (s *mockSession) handlePacket(addr interface{}, hdr *publicHeader, data []byte) {
s.packetCount++
}

10
session.go
View File

@@ -147,7 +147,7 @@ func (s *Session) Run() {
case <-s.closeChan:
return
case p := <-s.receivedPackets:
err = s.handlePacket(p.remoteAddr, p.publicHeader, p.data)
err = s.handlePacketImpl(p.remoteAddr, p.publicHeader, p.data)
if qErr, ok := err.(*protocol.QuicError); ok && qErr.ErrorCode == errorcodes.QUIC_DECRYPTION_FAILURE {
s.tryQueueingUndecryptablePacket(p)
continue
@@ -181,7 +181,7 @@ func (s *Session) Run() {
}
}
func (s *Session) handlePacket(remoteAddr interface{}, hdr *publicHeader, data []byte) error {
func (s *Session) handlePacketImpl(remoteAddr interface{}, hdr *publicHeader, data []byte) error {
r := bytes.NewReader(data)
// Calculate packet number
@@ -239,8 +239,8 @@ func (s *Session) handlePacket(remoteAddr interface{}, hdr *publicHeader, data [
return nil
}
// HandlePacket handles a packet
func (s *Session) HandlePacket(remoteAddr interface{}, hdr *publicHeader, data []byte) {
// handlePacket handles a packet
func (s *Session) handlePacket(remoteAddr interface{}, hdr *publicHeader, data []byte) {
s.receivedPackets <- receivedPacket{remoteAddr: remoteAddr, publicHeader: hdr, data: data}
}
@@ -614,7 +614,7 @@ func (s *Session) tryQueueingUndecryptablePacket(p receivedPacket) {
func (s *Session) tryDecryptingQueuedPackets() {
for _, p := range s.undecryptablePackets {
s.HandlePacket(p.remoteAddr, p.publicHeader, p.data)
s.handlePacket(p.remoteAddr, p.publicHeader, p.data)
}
s.undecryptablePackets = s.undecryptablePackets[:0]
}

2
session_test.go
View File

@@ -538,7 +538,7 @@ var _ = Describe("Session", func() {
hdr := &publicHeader{
PacketNumber: protocol.PacketNumber(i + 1),
}
session.HandlePacket(nil, hdr, []byte("foobar"))
session.handlePacket(nil, hdr, []byte("foobar"))
}
session.Run()